Add C++ benchmarks: FileHandle sequential read (part 2/n) #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
kingcrimsontianyu
added
breaking
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 26, 2025
This PR introduces two changes in KvikIO C++ API: - For the `pread` (and `pwrite` if applicable) method in `FileHandle`, `RemoteHandle` and `MmapHandle`'s , this PR adds the thread pool as a function parameter. By default, the global thread pool is used. - After previous PR's cleanup (https://github.com/rapidsai/kvikio/pull/851/files/30543a3ccb953b0eb2afb7bb91d36ceda482dd69#r2432486309), the `thread_pool_wrapper` class merely forwards calls without adding useful functionality. This PR removes it and adds a simple type alias `ThreadPool` for the underlying `BS:thread_pool`. This PR is a dependency of #874 which facilitates investigation into a multi-drive scaling problem reported by #850. Authors: - Tianyu Liu (https://github.com/kingcrimsontianyu) Approvers: - Mads R. B. Kristensen (https://github.com/madsbk) URL: #876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.